Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docker file and docker compose to dockerize rolling #127

Draft
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Draft

Added docker file and docker compose to dockerize rolling #127

wants to merge 1 commit into from

Conversation

shivangvijay
Copy link
Contributor

I am working on issue #111, but I am unable to test it because my system only has ROS Humble, and the build is failing in that ROS version. Therefore, for testing purposes, I have dockerized the code for ROS Rolling. Let me know if this is helpful, and then I will update the README file with the Docker steps.

The output look like:-
Screenshot from 2024-03-08 19-15-10

@clalancette
Copy link
Collaborator

Long-term, we aren't going to want to host a Dockerfile here; we have Dockerfiles for all of ROS 2 available, and we'll want rmw_zenoh to be part of that. Short-term, we aren't quite ready for this kind of thing. So I'm going to mark this is a draft for now (since it is in the same status as #68).

@clalancette clalancette marked this pull request as draft March 8, 2024 14:00
@shivangvijay
Copy link
Contributor Author

Ok @clalancette . But why the build pipeline failed? I didn't change any core stack just added 3 files (docker related).

@clalancette
Copy link
Collaborator

Ok @clalancette . But why the build pipeline failed? I didn't change any core stack just added 3 files (docker related).

That's because we are in the middle of a transition to Ubuntu 24.04, and are still working through some problems. It has nothing to do with this pull request directly.

@shivangvijay
Copy link
Contributor Author

Ok @clalancette . But why the build pipeline failed? I didn't change any core stack just added 3 files (docker related).

That's because we are in the middle of a transition to Ubuntu 24.04, and are still working through some problems. It has nothing to do with this pull request directly.

Ok Ok. I don't see any ticket of this issue, If you raise that I can work on this, I have Ubuntu 24.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivangvijay @clalancette